feat(jobs): acp_events_purge runner (retention-based cron cleanup)

This commit is contained in:
2026-05-07 17:39:57 +08:00
parent e03df47b71
commit 4c19ce29ca
2 changed files with 101 additions and 0 deletions
+41
View File
@@ -0,0 +1,41 @@
package runners
import (
"context"
"log/slog"
"time"
)
// AcpEventsPurgeRepo is the minimal repo surface this runner needs.
// internal/acp.Repository satisfies it via an adapter in app.go.
type AcpEventsPurgeRepo interface {
PurgeEventsBefore(ctx context.Context, before time.Time) (int64, error)
}
// AcpEventsPurge deletes acp_events older than retention. Periodic; idempotent.
type AcpEventsPurge struct {
repo AcpEventsPurgeRepo
retention time.Duration
log *slog.Logger
}
// NewAcpEventsPurge builds the purger.
func NewAcpEventsPurge(repo AcpEventsPurgeRepo, retention time.Duration, log *slog.Logger) *AcpEventsPurge {
if log == nil {
log = slog.Default()
}
return &AcpEventsPurge{repo: repo, retention: retention, log: log}
}
// Run purges once.
func (r *AcpEventsPurge) Run(ctx context.Context) {
cutoff := time.Now().Add(-r.retention)
rows, err := r.repo.PurgeEventsBefore(ctx, cutoff)
if err != nil {
r.log.Error("acp_events.purge", "err", err.Error())
return
}
if rows > 0 {
r.log.Info("acp_events.purged", "count", rows, "before", cutoff.UTC().Format(time.RFC3339))
}
}
@@ -0,0 +1,60 @@
package runners_test
import (
"context"
"errors"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/yan1h/agent-coding-workflow/internal/jobs/runners"
)
type fakeAcpEventsPurgeRepo struct {
purged int64
purgeErr error
capturedCutoff time.Time
called bool
}
func (f *fakeAcpEventsPurgeRepo) PurgeEventsBefore(_ context.Context, before time.Time) (int64, error) {
f.called = true
f.capturedCutoff = before
if f.purgeErr != nil {
return 0, f.purgeErr
}
return f.purged, nil
}
func TestAcpEventsPurge_RunCallsPurgeWithCorrectCutoff(t *testing.T) {
t.Parallel()
repo := &fakeAcpEventsPurgeRepo{purged: 5}
retention := 168 * time.Hour
r := runners.NewAcpEventsPurge(repo, retention, discardLogger())
before := time.Now()
r.Run(context.Background())
after := time.Now()
require.True(t, repo.called)
expectedFloor := before.Add(-retention).Add(-time.Second)
expectedCeil := after.Add(-retention).Add(time.Second)
assert.True(t, !repo.capturedCutoff.Before(expectedFloor) && !repo.capturedCutoff.After(expectedCeil),
"cutoff %s outside [%s, %s]", repo.capturedCutoff, expectedFloor, expectedCeil)
}
func TestAcpEventsPurge_RunErrorDoesNotPanic(t *testing.T) {
t.Parallel()
repo := &fakeAcpEventsPurgeRepo{purgeErr: errors.New("db down")}
r := runners.NewAcpEventsPurge(repo, time.Hour, discardLogger())
require.NotPanics(t, func() { r.Run(context.Background()) })
assert.True(t, repo.called)
}
func TestAcpEventsPurge_NoRowsIsNoOp(t *testing.T) {
t.Parallel()
repo := &fakeAcpEventsPurgeRepo{purged: 0}
r := runners.NewAcpEventsPurge(repo, time.Hour, discardLogger())
require.NotPanics(t, func() { r.Run(context.Background()) })
assert.True(t, repo.called)
}