Commit Graph

18 Commits

Author SHA1 Message Date
q792602257 a00f5a9efd refactor(mcp): apply Part 1 review I1+I3+I4+I5
- Rename MCPToken -> Token (mcp.Token reads cleaner; zero external callers yet)
- IssueSystemToken: guard against nil ACPSessionID / UserID (early input validation)
- TokenService: inject now func for clock injection (parity with RateLimiter)
- Repository CHECK constraint tests: assert wrapped CodeInternal

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-05-08 10:28:49 +08:00
q792602257 71a3a85b26 fix(mcp): code review I2 — admin expires_at must be future + Part 3 tx TODO + scope JSON round-trip tests
- IssueAdmin now rejects past/now ExpiresAt with CodeMcpTokenExpiresRequired
- TestIssueAdmin_ExpiresMustBeFuture covers the new path
- IssueSystemToken doc comment notes pgRepo currently ignores ctx tx; Part 3
  must add Repository.WithTx for true same-transaction guarantee with
  acp_sessions (spec §6.1)
- New scope_test.go (whitebox) verifies JSON round-trip preserves nil-vs-empty
  semantics on Tools / ProjectIDs and exercises AllowsTool / AllowsProject
  edges that Authenticate / future tool gating depend on
2026-05-08 08:30:26 +08:00
q792602257 c046d77a6e test(mcp): auth middleware + rate limiter tests 2026-05-08 08:11:02 +08:00
q792602257 e1e6508c4c feat(mcp): rate limit middleware (per-token + global token bucket, 1-min window) 2026-05-08 08:08:13 +08:00
q792602257 416a7d5023 feat(mcp): auth middleware (Bearer + ?token= fallback) 2026-05-08 08:06:41 +08:00
q792602257 8031579487 test(mcp): TokenService unit tests with fake repo 2026-05-08 08:04:54 +08:00
q792602257 7d9cd4bf6b feat(mcp): TokenService.Revoke + RevokeBySession (with audit) 2026-05-08 08:02:11 +08:00
q792602257 796e1e0d4c feat(mcp): TokenService.Authenticate (hash lookup + revoked/expired check + async last_used) 2026-05-08 08:00:35 +08:00
q792602257 0081ad6e49 feat(mcp): TokenService.IssueSystemToken (with default scope + 24h TTL) 2026-05-08 07:59:00 +08:00
q792602257 d1573bde09 feat(mcp): TokenService skeleton + IssueAdmin 2026-05-08 07:57:17 +08:00
q792602257 4071778930 test(mcp): RevokeBySession + ReapStaleSystemTokens integration 2026-05-08 07:27:59 +08:00
q792602257 d431b8103d test(mcp): repository CRUD + CHECK constraints + filter + purge integration 2026-05-08 07:25:21 +08:00
q792602257 bb512c0029 feat(mcp): repository RevokeBySession + ReapStaleSystemTokens + PurgeExpired 2026-05-08 07:22:16 +08:00
q792602257 21f29a68b5 feat(mcp): repository List + UpdateLastUsed + Revoke + DeleteByID 2026-05-08 07:20:19 +08:00
q792602257 3d16e4a877 feat(mcp): repository skeleton + Create + GetByHash + GetByID 2026-05-08 07:18:09 +08:00
q792602257 29b4c50888 feat(mcp): plaintext token generator + SHA-256 hash helper 2026-05-08 07:12:43 +08:00
q792602257 a3710c8645 feat(mcp): domain types — Issuer / Scope / MCPToken + helpers 2026-05-08 07:11:03 +08:00
q792602257 39f57df882 feat(mcp): sqlc queries for mcp_tokens (CRUD + revoke + reaper + purge) 2026-05-08 07:07:47 +08:00