feat(host-agent): start local console by default

apps/device-host-agent/tests/test_app.py

@@ -362,7 +362,7 @@ def test_main_task_cancellation_waits_for_active_work_shutdown() -> None:
     asyncio.run(scenario())
 
 
-def test_console_enabled_serves_http_and_shuts_down_cleanly(tmp_path) -> None:
+def test_console_serves_http_and_shuts_down_cleanly(tmp_path) -> None:
     async def scenario() -> None:
         port = _free_loopback_port()
         config = HostAgentConfig(
@@ -371,7 +371,6 @@ def test_console_enabled_serves_http_and_shuts_down_cleanly(tmp_path) -> None:
             token="secret",
             identity_path=tmp_path / "host_identity.json",
             local_account_path=tmp_path / "host_local_account.json",
-            console_enabled=True,
             console_bind_host="127.0.0.1",
             console_port=port,
         )
@@ -449,9 +448,9 @@ def test_console_enabled_serves_http_and_shuts_down_cleanly(tmp_path) -> None:
     asyncio.run(scenario())
 
 
-def test_console_disabled_by_default_opens_no_socket(tmp_path, monkeypatch) -> None:
+def test_console_is_created_by_default(tmp_path, monkeypatch) -> None:
     monkeypatch.chdir(tmp_path)
     application = create_application(config=_config(), manager=DeviceManager())
 
-    assert application.console_server is None
+    assert application.console_server is not None
     asyncio.run(application.client.aclose())

apps/device-host-agent/tests/test_config.py

@@ -104,10 +104,9 @@ def test_load_host_agent_config_rejects_invalid_values(
         load_host_agent_config(overrides)
 
 
-def test_console_defaults_are_disabled_and_do_not_trigger_validation() -> None:
+def test_console_defaults_are_loopback_bound() -> None:
     config = load_host_agent_config({})
 
-    assert config.console_enabled is False
     assert config.console_bind_host == "127.0.0.1"
     assert config.console_port == 8765
     assert config.console_allow_non_loopback is False
@@ -115,18 +114,10 @@ def test_console_defaults_are_disabled_and_do_not_trigger_validation() -> None:
     assert config.console_history_limit == 200
 
 
-def test_console_enabled_with_default_loopback_bind_passes() -> None:
-    config = load_host_agent_config({"HOST_AGENT_CONSOLE_ENABLED": "true"})
-
-    assert config.console_enabled is True
-    assert config.console_bind_host == "127.0.0.1"
-
-
 @pytest.mark.parametrize("bind_host", ["127.0.0.1", "localhost", "::1"])
-def test_console_enabled_with_loopback_bind_host_passes(bind_host: str) -> None:
+def test_console_loopback_bind_host_passes(bind_host: str) -> None:
     config = load_host_agent_config(
         {
-            "HOST_AGENT_CONSOLE_ENABLED": "true",
             "HOST_AGENT_CONSOLE_BIND_HOST": bind_host,
         }
     )
@@ -134,20 +125,18 @@ def test_console_enabled_with_loopback_bind_host_passes(bind_host: str) -> None:
     assert config.console_bind_host == bind_host
 
 
-def test_console_enabled_with_non_loopback_bind_without_opt_in_raises() -> None:
+def test_console_non_loopback_bind_without_opt_in_raises() -> None:
     with pytest.raises(HostAgentConfigurationError):
         load_host_agent_config(
             {
-                "HOST_AGENT_CONSOLE_ENABLED": "true",
                 "HOST_AGENT_CONSOLE_BIND_HOST": "0.0.0.0",
             }
         )
 
 
-def test_console_enabled_with_non_loopback_bind_with_opt_in_succeeds() -> None:
+def test_console_non_loopback_bind_with_opt_in_succeeds() -> None:
     config = load_host_agent_config(
         {
-            "HOST_AGENT_CONSOLE_ENABLED": "true",
             "HOST_AGENT_CONSOLE_BIND_HOST": "0.0.0.0",
             "HOST_AGENT_CONSOLE_ALLOW_NON_LOOPBACK": "true",
         }
@@ -157,24 +146,15 @@ def test_console_enabled_with_non_loopback_bind_with_opt_in_succeeds() -> None:
     assert config.console_allow_non_loopback is True
 
 
-def test_console_disabled_with_non_loopback_bind_does_not_raise() -> None:
-    config = load_host_agent_config({"HOST_AGENT_CONSOLE_BIND_HOST": "0.0.0.0"})
-
-    assert config.console_enabled is False
-    assert config.console_bind_host == "0.0.0.0"
-
-
 def test_console_env_vars_parse_numeric_and_bool_fields() -> None:
     config = load_host_agent_config(
         {
-            "HOST_AGENT_CONSOLE_ENABLED": "1",
             "HOST_AGENT_CONSOLE_PORT": "9001",
             "HOST_AGENT_CONSOLE_SESSION_TTL_SECONDS": "3600",
             "HOST_AGENT_CONSOLE_HISTORY_LIMIT": "50",
         }
     )
 
-    assert config.console_enabled is True
     assert config.console_port == 9001
     assert config.console_session_ttl_seconds == 3600
     assert config.console_history_limit == 50