agentic-mobile-control/tests/test_cloud_sdk_api.py

"""Unit tests for cloud.sdk.api (task 7.8)."""

from __future__ import annotations

import pytest

from cloud.config import CloudConfig
from cloud.plugins import PluginRegistry
from cloud.pool import DevicePool
from cloud.sdk.api import (
    AuthProvider,
    NullAuthProvider,
    Principal,
    create_cloud_router,
)
from cloud.scheduler import TaskConstraints, TaskScheduler
from cloud.store import CloudStore
from core.models import Device


pytest.importorskip("fastapi")
from fastapi import FastAPI  # noqa: E402
from fastapi.testclient import TestClient  # noqa: E402


def _config() -> CloudConfig:
    return CloudConfig(
        sync_interval_seconds=30,
        stale_after_seconds=60,
        max_queue_depth=100,
        default_assignment_strategy="fifo_match",
        api_version_prefix="/v1",
        db_path="cloud/cloud.sqlite3",
    )


def _build_app(
    tmp_path,
    *,
    auth_provider: AuthProvider | None = None,
    pool: DevicePool | None = None,
    scheduler: TaskScheduler | None = None,
    plugin_registry: PluginRegistry | None = None,
):
    store = CloudStore(tmp_path / "cloud.sqlite3")
    pool = pool or DevicePool(store, _config())
    scheduler = scheduler or TaskScheduler(pool, store, _config())
    plugin_registry = plugin_registry or PluginRegistry(store)
    app = FastAPI()
    app.include_router(
        create_cloud_router(
            pool=pool,
            scheduler=scheduler,
            plugin_registry=plugin_registry,
            auth_provider=auth_provider,
        )
    )
    return app, pool, scheduler, plugin_registry


def _client_for(app) -> TestClient:
    return TestClient(app)


def test_null_auth_provider_allows_submit_and_status_round_trip(tmp_path) -> None:
    app, pool, scheduler, _ = _build_app(tmp_path)
    # Plant a device so the listing route has something to show.
    pool.sync_host_devices(
        "host-local",
        [Device(id="dev-1", driver_type="wda", status="idle")],  # type: ignore[arg-type]
        address="10.0.0.1:8000",
    )

    client = _client_for(app)

    submission = client.post("/v1/tasks", json={"goal": "open settings"})
    assert submission.status_code == 201, submission.text
    task_id = submission.json()["task_id"]

    status = client.get(f"/v1/tasks/{task_id}")
    assert status.status_code == 200, status.text
    body = status.json()
    assert body["id"] == task_id
    assert body["status"] == "queued"
    assert body["goal"] == "open settings"


def test_unknown_task_id_returns_404(tmp_path) -> None:
    app, _, _, _ = _build_app(tmp_path)
    client = _client_for(app)
    resp = client.get("/v1/tasks/does-not-exist")
    assert resp.status_code == 404, resp.text


def test_device_and_host_listing_reflect_pool_state(tmp_path) -> None:
    app, pool, _, _ = _build_app(tmp_path)
    pool.sync_host_devices(
        "host-a",
        [
            Device(id="a-dev-1", driver_type="wda", status="idle"),  # type: ignore[arg-type]
            Device(id="a-dev-2", driver_type="wda", status="busy"),  # type: ignore[arg-type]
        ],
        address="a:8000",
    )
    pool.sync_host_devices(
        "host-b",
        [Device(id="b-dev-1", driver_type="wda", status="idle")],  # type: ignore[arg-type]
        address="b:8000",
    )

    client = _client_for(app)
    devices = client.get("/v1/devices").json()
    assert {d["device_id"] for d in devices} == {"a-dev-1", "a-dev-2", "b-dev-1"}
    by_host = {d["device_id"]: d["host_id"] for d in devices}
    assert by_host == {
        "a-dev-1": "host-a",
        "a-dev-2": "host-a",
        "b-dev-1": "host-b",
    }

    hosts = client.get("/v1/hosts").json()
    assert {h["host_id"] for h in hosts} == {"host-a", "host-b"}
    assert all("last_seen_at" in h for h in hosts)


def test_plugin_listing_and_registration_round_trip(tmp_path) -> None:
    app, _, _, _ = _build_app(tmp_path)
    client = _client_for(app)

    assert client.get("/v1/plugins").json() == []

    payload = {
        "name": "demo-tool",
        "version": "1.0.0",
        "entry_point_kind": "tool",
        "target": "cloud.store:CloudStore",
    }
    resp = client.post("/v1/plugins", json=payload)
    assert resp.status_code == 201, resp.text
    body = resp.json()
    assert body["name"] == "demo-tool"
    assert body["entry_point_kind"] == "tool"
    assert body["wired"] is False

    listed = client.get("/v1/plugins").json()
    assert len(listed) == 1
    assert listed[0]["name"] == "demo-tool"


def test_duplicate_plugin_returns_conflict(tmp_path) -> None:
    app, _, _, _ = _build_app(tmp_path)
    client = _client_for(app)

    payload = {
        "name": "dup",
        "version": "1.0.0",
        "entry_point_kind": "tool",
        "target": "cloud.store:CloudStore",
    }
    first = client.post("/v1/plugins", json=payload)
    assert first.status_code == 201
    second = client.post("/v1/plugins", json=payload)
    assert second.status_code == 409


class _RejectingAuthProvider:
    def authenticate(self, request: object) -> Principal | None:
        return None


def test_rejecting_auth_provider_blocks_every_route(tmp_path) -> None:
    app, _, _, _ = _build_app(tmp_path, auth_provider=_RejectingAuthProvider())
    client = _client_for(app)

    assert client.post("/v1/tasks", json={"goal": "x"}).status_code == 401
    assert client.get("/v1/tasks/whatever").status_code == 401
    assert client.get("/v1/devices").status_code == 401
    assert client.get("/v1/hosts").status_code == 401
    assert client.get("/v1/plugins").status_code == 401
    assert client.post("/v1/plugins", json={
        "name": "x",
        "version": "1",
        "entry_point_kind": "tool",
        "target": "cloud.store:CloudStore",
    }).status_code == 401


def test_default_null_auth_provider_is_used_when_omitted(tmp_path) -> None:
    # No auth_provider kwarg -> defaults to NullAuthProvider
    app, _, _, _ = _build_app(tmp_path)
    client = _client_for(app)

    # Should NOT 401 (i.e., NullAuthProvider lets everything through).
    assert client.get("/v1/plugins").status_code == 200
    assert client.get("/v1/devices").status_code == 200


def test_submit_with_constraints(tmp_path) -> None:
    app, pool, _, _ = _build_app(tmp_path)
    pool.sync_host_devices(
        "host-local",
        [Device(id="dev-1", driver_type="wda", status="idle")],  # type: ignore[arg-type]
    )
    client = _client_for(app)

    resp = client.post(
        "/v1/tasks",
        json={
            "goal": "x",
            "constraints": {"driver_type": "wda", "capability_tags": []},
        },
    )
    assert resp.status_code == 201, resp.text
    task_id = resp.json()["task_id"]

    # And the device should match if we run assign() manually via the scheduler.
    status = client.get(f"/v1/tasks/{task_id}").json()
    assert status["status"] == "queued"